Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] [Relay] Dynamic squeeze #9095

Merged
merged 11 commits into from
Sep 28, 2021
Merged

[ONNX] [Relay] Dynamic squeeze #9095

merged 11 commits into from
Sep 28, 2021

Conversation

CircleSpin
Copy link
Contributor

mbrookhart
mbrookhart reviewed Sep 23, 2021
View reviewed changes
Copy link
Contributor

@mbrookhart mbrookhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are a couple of formatting/lint issues, and there's one print still in here, but otherwise LGTM

AndrewZhaoLuo
AndrewZhaoLuo reviewed Sep 23, 2021
View reviewed changes
Copy link
Contributor

@AndrewZhaoLuo AndrewZhaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mostly. A few comments

@AndrewZhaoLuo
Copy link
Contributor

Please also change the title of this PR to something like "[ONNX] [Relay] Dynamic Squeeze"

@CircleSpin CircleSpin changed the title Dynamic squeeze [ONNX] [Relay] Dynamic squeeze Sep 23, 2021
@AndrewZhaoLuo AndrewZhaoLuo mentioned this pull request Sep 24, 2021
Merged
AndrewZhaoLuo
AndrewZhaoLuo reviewed Sep 27, 2021
View reviewed changes
Copy link
Contributor

@AndrewZhaoLuo AndrewZhaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, LGTM

@mbrookhart mbrookhart merged commit 5e46e75 into apache:main Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewZhaoLuo AndrewZhaoLuo AndrewZhaoLuo left review comments

@mbrookhart mbrookhart mbrookhart approved these changes

@anijain2305 anijain2305 Awaiting requested review from anijain2305

@areusch areusch Awaiting requested review from areusch

@comaniac comaniac Awaiting requested review from comaniac

@Huyuwei Huyuwei Awaiting requested review from Huyuwei

@jroesch jroesch Awaiting requested review from jroesch

@junrushao junrushao Awaiting requested review from junrushao

@jwfromm jwfromm Awaiting requested review from jwfromm

@kazum kazum Awaiting requested review from kazum

@MarisaKirisame MarisaKirisame Awaiting requested review from MarisaKirisame

@merrymercy merrymercy Awaiting requested review from merrymercy

@siju-samuel siju-samuel Awaiting requested review from siju-samuel

@slyubomirsky slyubomirsky Awaiting requested review from slyubomirsky

@srkreddy1238 srkreddy1238 Awaiting requested review from srkreddy1238

@tqchen tqchen Awaiting requested review from tqchen

@vinx13 vinx13 Awaiting requested review from vinx13

@wweic wweic Awaiting requested review from wweic

@yzhliu yzhliu Awaiting requested review from yzhliu

@zhiics zhiics Awaiting requested review from zhiics

@ZihengJiang ZihengJiang Awaiting requested review from ZihengJiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CircleSpin @AndrewZhaoLuo @mbrookhart